React-native based library generator does not include test-setup.ts in tsconfig.spec.json

[jsve]

Current Behavior

In a generated a react-native library, there are typescript errors when using functions from @testing-library/jest-native/extend-expect in .spec files.

The reason is likely that ./test-setup.ts is not included here:

nx/packages/react-native/src/generators/library/library.spec.ts

Line 236 in 84d96cc

"src/**/*.d.ts"

The issue is the same for the expo-generator.

Expected Behavior

Since the generator includes test-setup.ts and includes it in jest.config, typescript should also be configured to use this.

GitHub Repo

No response

Steps to Reproduce

1. nx generate @nx/react-native:library --name=test --projectNameAndRootFormat=as-provided --no-interactive
2. use one of the features from @testing-library/jest-native/extend-expect
3. see typescript complaining about the function not existing

Nx Report

Node   : 18.18.2
OS     : darwin-arm64
yarn   : 4.1.0
   
nx                 : 18.0.4
@nx/js             : 18.0.4
@nx/jest           : 18.0.4
@nx/linter         : 18.0.4
@nx/eslint         : 18.0.4
@nx/workspace      : 18.0.4
@nx/cypress        : 18.0.4
@nx/detox          : 18.0.4
@nx/devkit         : 18.0.4
@nx/eslint-plugin  : 18.0.4
@nx/expo           : 18.0.4
@nx/next           : 18.0.4
@nx/react          : 18.0.4
@nx/react-native   : 18.0.4
@nrwl/tao          : 18.0.4
@nx/vite           : 18.0.4
@nx/web            : 18.0.4
@nx/webpack        : 18.0.4
typescript         : 5.3.2

Failure Logs

No response

Package Manager Version

yarn 4.1.0

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[xiongemi]

fixed it in https://github.com/nrwl/nx/pull/23314/files