Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx.json option plugins.[].exclude crashes #22737

Closed
4 tasks
yjaaidi opened this issue Apr 9, 2024 · 1 comment · Fixed by #22738
Closed
4 tasks

Nx.json option plugins.[].exclude crashes #22737

yjaaidi opened this issue Apr 9, 2024 · 1 comment · Fixed by #22738

Comments

@yjaaidi
Copy link
Contributor

yjaaidi commented Apr 9, 2024

Current Behavior

When using the exclude option, the following error happens:

TypeError: Cannot read properties of undefined (reading 'some')
 at createProjectConfigurations (node_modules/nx/src/project-graph/utils/project-configuration-utils.js:240:46)

The problem comes from a typo here:

const excluded = include.some((excludedPattern) =>

which should be:

const excluded = exclude.some(...)

I guess that this would be worth a test 😇

Expected Behavior

exclude option should work as documented 😊

GitHub Repo

No response

Steps to Reproduce

Nx Report

Node   : 21.7.2
OS     : darwin-arm64
yarn   : 3.5.1

nx                 : 18.2.3
@nx/js             : 18.2.3
@nx/jest           : 18.2.3
@nx/linter         : 18.2.3
@nx/eslint         : 18.2.3
@nx/workspace      : 18.2.3
@nx/angular        : 18.2.3
@nx/cypress        : 18.2.3
@nx/devkit         : 18.2.3
@nrwl/devkit       : 18.1.0-beta.2
@nx/eslint-plugin  : 18.2.3
@nx/node           : 18.2.3
@nx/plugin         : 18.2.3
@nx/rollup         : 18.2.3
@nrwl/tao          : 18.1.0-beta.2
@nx/vite           : 18.2.3
@nx/web            : 18.2.3
@nx/webpack        : 18.2.3
typescript         : 5.4.4
---------------------------------------
Registered Plugins:
@nx/vite/plugin
---------------------------------------
Community plugins:
@analogjs/vite-plugin-angular : 1.1.2
@monodon/rust                 : 1.4.0
---------------------------------------
The following packages should match the installed version of nx
  - @nrwl/devkit@18.1.0-beta.2
  - @nrwl/tao@18.1.0-beta.2

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@yjaaidi yjaaidi changed the title Nx plugins.[].exclude is broken Nx.json option plugins.[].exclude crashes Apr 9, 2024
yjaaidi added a commit to yjaaidi/nx that referenced this issue Apr 9, 2024
yjaaidi added a commit to yjaaidi/nx that referenced this issue Apr 9, 2024
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant