You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
it creates problems if the developer pushed without adding the lock files changes
or if you later on needed to revert/drop commit regarding only one update (e.g. to revert cypress update because it started failing but keep everything else), because it only reverted the change in package.json only then the package.json and the lock file are out of sync
Expected Behavior
to include the appropriate lock files in the commits that update dependencies, in the reprod repo for example to include package-lock.json
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
## Current Behavior
<!-- This is the behavior we have today -->
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes#23505
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
## Current Behavior
<!-- This is the behavior we have today -->
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes#23505
(cherry picked from commit 6be46cf)
Current Behavior
when running
nx migrate --run-migrations --create-commits
and one migration updatepackage.json
, the lock files e.g.yarn.lock
,package-lock.json
... etc doesn't get included in the associated commithere is an example
https://github.com/robertIsaac/daemon-process-terminated-reprod/commits/master/
you can see that robertIsaac/daemon-process-terminated-reprod@1d4dd50 included only
package.json
as well as robertIsaac/daemon-process-terminated-reprod@5b84127 robertIsaac/daemon-process-terminated-reprod@d480e70 and robertIsaac/daemon-process-terminated-reprod@20f3e89it creates problems if the developer pushed without adding the lock files changes
or if you later on needed to revert/drop commit regarding only one update (e.g. to revert cypress update because it started failing but keep everything else), because it only reverted the change in package.json only then the package.json and the lock file are out of sync
Expected Behavior
to include the appropriate lock files in the commits that update dependencies, in the reprod repo for example to include package-lock.json
GitHub Repo
https://github.com/robertIsaac/daemon-process-terminated-reprod
Steps to Reproduce
npx create-nx-workspace@17.0.0
npx nx migrate latest
npx nx migrate --run-migrations --create-commits
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: