Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown when running Storybook config schematic with no declared components #2383

Closed
BuckyMaler opened this issue Jan 27, 2020 · 3 comments · Fixed by #2384
Closed

Error thrown when running Storybook config schematic with no declared components #2383

BuckyMaler opened this issue Jan 27, 2020 · 3 comments · Fixed by #2384
Labels
community This is a good first issue for contributing outdated scope: storybook Issues related to Storybook support in Nx type: bug

Comments

@BuckyMaler
Copy link
Contributor

Expected Behavior

I wouldn't expect an error related to components when generateStories is set to false.

Current Behavior

An error is thrown related to components when generateStories is set to false.

Failure Information (for bugs)

Steps to Reproduce

1. yarn create-playground
2. ng g lib mylib --prefix mylib
3. ng g @nrwl/angular:storybook-configuration mylib --configure-cypress --generate-cypress-specs false --generate-stories false

Failure Logs

Screen Shot 2020-01-26 at 9 00 40 PM

BuckyMaler added a commit to BuckyMaler/nx that referenced this issue Jan 27, 2020
@FrozenPandaz FrozenPandaz added community This is a good first issue for contributing scope: storybook Issues related to Storybook support in Nx type: bug labels Jan 29, 2020
@FrozenPandaz
Copy link
Collaborator

I agree, it should not throw an error.

Would someone like to attempt fixing this?

@BuckyMaler
Copy link
Contributor Author

I have an open PR. #2384 The CI build is failing, but I think the error is unrelated to my changes.

BuckyMaler added a commit to BuckyMaler/nx that referenced this issue Feb 8, 2020
BuckyMaler added a commit to BuckyMaler/nx that referenced this issue Feb 14, 2020
vsavkin pushed a commit that referenced this issue Feb 19, 2020
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community This is a good first issue for contributing outdated scope: storybook Issues related to Storybook support in Nx type: bug
Projects
None yet
2 participants