Nx.json - Be able to add as implicit dependency value a RegExp

[mauriziovitale]

Currently, Nx does not allow you to specify a regexp as the value of an implicit dependency such as package.json

Prerequisites

  "npmScope": "mycompany",
  "implicitDependencies": {
    "angular.json": "*",
    "package.json": {
      "dependencies": "@mycompany/lib/*",
      "devDependencies": "*"
    }

Please answer the following questions for yourself before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.

• I am running the latest version
• I checked the documentation (nx.dev) and found no answer
• I checked to make sure that this issue has not already been filed
• I'm reporting the issue to the correct repository (not related to React, Angular or any dependency)

Expected Behavior

Should trigger the target action only if the @mycompany/lib has been changed

Please describe the behavior you are expecting

Current Behavior

What is the current behavior?

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. step 1
2. step 2
3. ...

If you can provide steps to reproduce from scratch, that would be enormously appreciated (i.e. where the first step is npx create-nx-workspace@latest repro-workspace)

Context

Please provide any relevant information about your setup:

Example of nx.json

  "npmScope": "mycompany",
  "implicitDependencies": {
    "angular.json": "*",
    "package.json": {
      "dependencies": "@mycompany/lib/*",
      "devDependencies": "*"
    }

A minimal reproduction scenario allows us to quickly confirm a bug (or point out coding problem) as well as confirm that we are fixing the right problem.

Failure Logs

Please include any relevant log snippets or files here.

Other

Any other relevant information that will help us help you.

[github-actions]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nrwl community! 🙏

[mauriziovitale]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nrwl community! 🙏

It would be great to have it.

[vsavkin]

Sorry. The issue was marked by mistake. I removed the label.

[mehrad-rafigh]

Hey guys, we are really looking for this feature. Is there any plan to implement this?

[bekos]

hi @mehrad-rafigh .... since v10.1 you can use globs in implicitDependencies files paths, like "styles/**/*.css": "*". Does this solve your issue?

[mehrad-rafigh]

Hi @bekos. I'm afraid it doesn't solve my issue.
I would need to be able to ignore the version property in package.json. We are using semantic release and every PR wants to build everything.
Would I be able to achieve this with v10.1?

[bekos]

@mehrad-rafigh sorry I missed your response! no, it doesn't seem to be supported 😞 the problem I see though, is that the proposed syntax is not compliant with the current format, as the value of implicitDependencies is always the affected projects 🤔 So a syntax that would make more sense could be:

"implicitDependencies": {
  "angular.json": "*",
  "package.json": {
    "dependencies": {
      "@mycompany/lib/*": ["myapp"],
     },
    "devDependencies": "*"
  }
}

I will try to take a look and see if this an easy change 😃

[bekos]

hi @mehrad-rafigh @mauriziovitale 😃 can you please elaborate on your actual case? we are trying to understand if this would be a useful feature 🤔

[mehrad-rafigh]

Hi @bekos. Sorry for the late reply. For my use case I want all properties of package.json except version to be implicit dependencies. We are using semantic release to do the release management in an automated way. So everytime we merge a PR, semantic-release creates a new release and updates the version property in our package.json. Since package.json is an implicit dependency, running nx affected:build or any other affected script will build/test all libs and apps of our monorepo. This is a huge hussle for us and our biggest bottleneck. Hope that information helps.

[bekos]

hi @mehrad-rafigh 😃 thx for the info. Do you really care for all the other properties in package.json or just the dependencies? Because i this case you could already have something like this:

"implicitDependencies": {
  "angular.json": "*",
  "package.json": {
    "dependencies": "*",
    "devDependencies": "*"
  }
}

[mehrad-rafigh]

I actually have to check that. Is that functionality already released @bekos?

[bekos]

@mehrad-rafigh Yes.

[mehrad-rafigh]

Will give it a try, when I'm back at the office

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.