Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx > 17 does not pass through cli npm arguments #26537

Open
1 of 4 tasks
gkamperis opened this issue Jun 13, 2024 · 2 comments
Open
1 of 4 tasks

nx > 17 does not pass through cli npm arguments #26537

gkamperis opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
scope: core core nx functionality type: bug

Comments

@gkamperis
Copy link

Current Behavior

npm run start -- --project=my-app
the --project arg is not passed through

if nx.json has a defaultProject defined it will be run instead but if not then get the error

NX Both project and target have to be specified

Expected Behavior

all args should pass through - worked with v17

GitHub Repo

https://github.com/gkamperis/nx-incremental-bug

Steps to Reproduce

  1. checkout the repo
  2. npm run start -- --project=my-app

Nx Report

NX   Report complete - copy this into the issue template

Node   : 22.2.0
OS     : win32-x64
npm    : 10.8.1

nx (global)        : 19.2.2
nx                 : 18.3.5
@nx/js             : 18.3.5
@nx/jest           : 18.3.5
@nx/linter         : 18.3.5
@nx/eslint         : 18.3.5
@nx/workspace      : 18.3.5
@nx/angular        : 18.3.5
@nx/devkit         : 18.3.5
@nx/eslint-plugin  : 18.3.5
@nrwl/tao          : 18.3.5
@nx/web            : 18.3.5
@nx/webpack        : 18.3.5
typescript         : 5.4.5

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@gkamperis gkamperis changed the title nx > 18.3.6 does not pass through cli npm arguments nx > 17 does not pass through cli npm arguments Jun 13, 2024
@FrozenPandaz FrozenPandaz added the scope: core core nx functionality label Jun 13, 2024
@elevenpassin
Copy link
Contributor

elevenpassin commented Jun 13, 2024

I tried to test this locally, but I was unfortunately not able to replicate this locally. As you can see from below logs, I was able to get the correct project running by using the --project option. I did add the defaultProject too here to nx graph

my-app

D:\Development\github\nx-exp\nx-incremental-bug on  λ npm run start -- --project=my-app

> @nx19/source@0.0.0 start
> nx serve --project=my-app


> nx run my-app:serve:development

- Generating browser application bundles (phase: setup)...
✔ Browser application bundle generation complete.

Initial chunk files   | Names         |  Raw size
vendor.js             | vendor        |   2.85 MB | 
polyfills.js          | polyfills     | 345.88 kB | 
styles.css, styles.js | styles        | 233.53 kB | 
main.js               | main          |  47.19 kB | 
runtime.js            | runtime       |   6.67 kB | 

                      | Initial total |   3.49 MB

Build at: 2024-06-13T20:02:37.611Z - Hash: b0f3c2a24dd91650 - Time: 21630ms

** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **


√ Compiled successfully.

my-app-m

D:\Development\github\nx-exp\nx-incremental-bug on  λ npm run start -- --project=my-app-m

> @nx19/source@0.0.0 start
> nx serve --project=my-app-m


> nx run my-app-m:serve:development

- Generating browser application bundles (phase: setup)...
 NX   Running target build for project my-lib:
- my-lib
> nx run my-lib:build:production
Building Angular Package

------------------------------------------------------------------------------
Building entry point '@nx19/my-lib'
------------------------------------------------------------------------------
- Compiling with Angular sources in Ivy full compilation mode.
✔ Compiling with Angular sources in Ivy full compilation mode.
Copying assets
Writing package manifest
Built @nx19/my-lib

------------------------------------------------------------------------------
Built Angular Package
 - from: D:\Development\github\nx-exp\nx-incremental-bug\libs\my-lib
 - to:   D:\Development\github\nx-exp\nx-incremental-bug\dist\libs\my-lib
------------------------------------------------------------------------------

Build at: 2024-06-13T20:14:31.930Z - Time: 1498ms

 NX   Successfully ran target build for project my-lib
✔ Browser application bundle generation complete.

Initial chunk files   | Names         |  Raw size
vendor.js             | vendor        |   2.85 MB | 
polyfills.js          | polyfills     | 345.88 kB | 
styles.css, styles.js | styles        | 233.55 kB | 
main.js               | main          |  52.25 kB | 
runtime.js            | runtime       |   6.67 kB | 

                      | Initial total |   3.49 MB

Build at: 2024-06-13T20:14:39.033Z - Hash: 1a9c089bf2e8c00b - Time: 10213ms

** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **


√ Compiled successfully.
✔ Browser application bundle generation complete.

Initial chunk files | Names   | Raw size
main.js             | main    | 52.25 kB | 
runtime.js          | runtime |  6.67 kB | 

3 unchanged chunks

Build at: 2024-06-13T20:14:39.426Z - Hash: 6b6b10dffdbc54cc - Time: 245ms

√ Compiled successfully.

It could definitely just be me but here's the steps I did:

  • Clone the example repo
  • Install, modify nx.json to have "defaultProject": "my-app"
  • Try to run the above commands.
  • I did try to stop the daemon and clear cache etc and try again and it's the same result.

@gkamperis
Copy link
Author

gkamperis commented Jun 14, 2024

hi @elevenpassin thanks for trying this out.

defaultProject is not required.
why did you add it?
removing it makes some commands throw which is something that needs to be looked at on its own right.
having it there masks the issue of the missing project and it proved a stealthy issue for us.

I did some further tests because before reporting I tried this in 3 different environments:

  • work - windows
  • work - CI linux
  • home - windows

in all cases I could not get to run the required project.

I realized that you might be using a different terminal app.
So I tried more things...

Windows at home - windows terminal - powershell does not work
Windows at home - cmd - works
Windows at work- windows terminal - powershell does not work
Windows at work - cmd - does not work
Linux CI - Jenkins - does not work
EDIT: in CI the workspace is created from scratch - no previous caching is at play

I also reinstalled everything - made sure global and repo Nx versions match - stopped daemon and nx reset.

Can you give another try with windows terminal/powershell?

Thanks in advance...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core core nx functionality type: bug
Projects
None yet
Development

No branches or pull requests

4 participants