feat(nx-plugin): use package and e2e folder instead of libs and apps in create-nx-plugin command #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in create-nx-plugin command
FrozenPandaz
approved these changes
Jun 5, 2020
| @@ -103,6 +90,23 @@ function createNxPlugin(workspaceName, pluginName) { | |||
| ); | |||
| } | |||
|
|
|||
| function updateWorkspace(workspaceName: string) { | |||
| console.log(`updating workspace...`); | |||
There was a problem hiding this comment.
Is this console.log intentional?
If so, maybe this can be more specific like.. "Setting workspace layout"? But I don't think it's necessary.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Creating a nx plugin workspace with
create-nx-pluginwill output a folder structure withlibsandapps.Expected Behavior
libsandappsare replaced withpackagesande2erespectfully.Related Issue(s)
Fixes #