Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix lint failures for npm packages #3827

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Circular dependencies check in lint rule fails because npm packages are passed in.

Expected Behavior

Lint rule does not fail because of imports to npm packages

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Sep 28, 2020

Nx Cloud Report

CI ran the following commands for commit b116379. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx build-base angular 9/28/2020, 8:43:56 PM
#000000 nx build-base create-nx-plugin 9/28/2020, 8:43:57 PM
#000000 nx build-base express 9/28/2020, 8:44:04 PM
#000000 nx build-base nest 9/28/2020, 8:44:04 PM
#000000 nx build-base next 9/28/2020, 8:44:06 PM
#000000 nx build-base react 9/28/2020, 8:44:04 PM
#000000 nx build-base storybook 9/28/2020, 8:43:57 PM
#000000 nx run-many --target=build --all --parallel 9/28/2020, 8:43:48 PM
#000000 nx run-many --target=e2e --projects=e2e-angular,e2e-bazel 9/28/2020, 8:43:54 PM
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest,e2e-nx-plugin 9/28/2020, 8:44:02 PM
#000000 nx run-many --target=e2e --projects=e2e-next 9/28/2020, 8:45:00 PM
#000000 nx run-many --target=e2e --projects=e2e-node 9/28/2020, 8:43:55 PM
#000000 nx run-many --target=e2e --projects=e2e-react 9/28/2020, 8:45:00 PM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 9/28/2020, 8:43:53 PM
#000000 nx run-many --target=e2e --projects=e2e-workspace,e2e-cli 9/28/2020, 8:44:12 PM
#000000 nx run-many --target=lint --all --parallel 9/28/2020, 8:46:35 PM
#000000 nx run-many --target=test --all --parallel 9/28/2020, 8:43:53 PM

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz merged commit f057978 into nrwl:master Sep 28, 2020
@FrozenPandaz FrozenPandaz deleted the lint-npm-fix branch September 28, 2020 22:31
Doginal pushed a commit to Doginal/nx that referenced this pull request Nov 25, 2020
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant