Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): Respect the "silent" and "outputPath" options to show the formatter results in the console output #4755

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

lucasvieirasilva
Copy link
Contributor

@lucasvieirasilva lucasvieirasilva commented Feb 10, 2021

Current Behavior

When running nx run {project}:lint with format and outputPath options in the workspace config for lint behaviour, I am still seeing the formatter result output in the console output.

Expected Behavior

When adding outputPath option, the formatter results should be hidden from the console output.

Related Issue(s)

Fixes #4754

@nx-cloud
Copy link

nx-cloud bot commented Feb 10, 2021

Nx Cloud Report

CI ran the following commands for commit 7ca7c66. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 2/10/2021, 3:42:41 PM
#000000 nx run-many --target=e2e --projects=e2e-angular 2/10/2021, 3:44:10 PM
#000000 nx run-many --target=e2e --projects=e2e-cypress 2/10/2021, 3:43:47 PM
#000000 nx run-many --target=e2e --projects=e2e-next,e2e-gatsby 2/10/2021, 3:45:47 PM
#000000 nx run-many --target=e2e --projects=e2e-react 2/10/2021, 3:44:02 PM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 2/10/2021, 3:43:50 PM
#000000 nx run-many --target=lint --all --parallel 2/10/2021, 3:45:18 PM
#000000 nx run-many --target=test --all --parallel 2/10/2021, 3:42:38 PM

Sent with 💌 from NxCloud.

@lucasvieirasilva lucasvieirasilva marked this pull request as ready for review February 10, 2021 16:59
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, thanks @lucasvieirasilva!

@JamesHenry JamesHenry merged commit 4133c05 into nrwl:master Feb 12, 2021
@Roemer
Copy link

Roemer commented Jul 15, 2021

What if I explicitely want this behavior? For example in the CI I want the report and locally I want the console output. So before, I had one command which did both. Now I need to have two, one for the file output and one for console output which share most things (like builder or lintFilePatterns).

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx lint with "format" and "outputPath" options is showing formatter results in console
3 participants