fix(linter): disable absolute paths within project

[meeroslav]

Current Behavior

If a project imports from itself using the full package name, the lint rule does not detect a circular dependency.

// In @happy-org/header library
// This should be a circular dependency
import { MyComponent } from '@happy-org/header';

Expected Behavior

The linter should report an error with information why the error happened.
e.g.

Only relative imports are allowed within the project. Absolute import found: @happy-org/header

Related Issue(s)

Fixes #2019

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CN9W1HU5D6WChSEkiVRdZR1Dsoqd
✅ Preview: https://nx-dev-git-fork-meeroslav-fix-linter-circular-ab-8a933e.vercel.app

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 8ccdf3e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx affected --target=build
	nx affected --target=e2e
	nx affected --target=lint
	nx affected --target=test

---

Sent with 💌 from NxCloud.

[FrozenPandaz]

LGTM! 🎉

[FrozenPandaz]

Can you see why the e2e tests are failing?

[meeroslav]

Looks like a timeout. I'll look into it tomorrow.

[vsavkin]

I think this can be a breaking change for a lot of folks. Should we have a flag that allows you to switch it off?

[meeroslav]

I think this can be a breaking change for a lot of folks. Should we have a flag that allows you to switch it off?

Good point, @vsavkin! I will add the flag

[Wykks]

Hello!

I can confirm that this is a breaking change, because I actually need to do this when using secondary entry point for a library. When code in the secondary entry point import something from the main entry point.

@meeroslav
You forgot to add the flag to the schema around here :

nx/packages/eslint-plugin-nx/src/rules/enforce-module-boundaries.ts

Lines 65 to 79 in 4b73b7c

	properties: {
	enforceBuildableLibDependency: { type: 'boolean' },
	allow: [{ type: 'string' }],
	depConstraints: [
	{
	type: 'object',
	properties: {
	sourceTag: { type: 'string' },
	onlyDependOnLibsWithTags: [{ type: 'string' }],
	},
	additionalProperties: false,
	},
	],
	},
	additionalProperties: false,

Unfortunately without it, eslint is rejecting the new config with a ""Configuration for rule "@nrwl/nx/enforce-module-boundaries" is invalid"

[meeroslav]

@Wykks Thank you for the fast feedback. The missing schema property definition was accidentally removed. I will add it asap.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.