-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): broken buildable libs importPath calculation #6429
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/D2ZgmUCxvKuGwTaFMQyA6gjrQ7pi [Deployment for 4b57df8 canceled] |
Nx Cloud ReportCI ran the following commands for commit 4b57df8. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
4d2e022
to
02b9bc0
Compare
Buildable libs with Angular Lib generator were broken due to additional `/` in the `importPath`.
02b9bc0
to
4b57df8
Compare
@FrozenPandaz @leosvelperez Can you give this a quick once over? It appears to be working locally, but I'd like an extra pair of eyes, just to make sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Buildable libs with Angular Lib generator were broken due to additional
/
in theimportPath
.Expected Behavior
Fix importPath calculation to allow buildable libs to behave correctly
Related Issue(s)
Fixes #