fix(core): close webpack compiler when build complete

[kazamov]

Call webpack close method when build complete according to . Fallback webpack 4 close method

Current Behavior

Currently the webpack compiler does not call the close method after the build complete, because webpack 4 does not have it. But it is crucial for the webpack 5 to be able to use persistent cache.

Expected Behavior

The close method of webpack compiler instance called when build complete. Fallback webpack 4 compiler instance with the close method.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/2xEjgV4hruiRSZPLXdYYG5jd7gCj
✅ Preview: Canceled

[Deployment for f2f6832 canceled]

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit f2f6832. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx affected --target=e2e --base=f3cd6028f7e82acc42605bb110aed992cd50b6ad
	nx affected --target=lint --base=f3cd6028f7e82acc42605bb110aed992cd50b6ad --parallel --max-parallel=4
	nx affected --target=test --base=f3cd6028f7e82acc42605bb110aed992cd50b6ad --parallel --max-parallel=2
	nx affected --target=build --base=f3cd6028f7e82acc42605bb110aed992cd50b6ad --parallel --max-parallel=3
	nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[kazamov]

@FrozenPandaz please take a look when you have time. I think it is an important change.

Didn't see failing build

[FrozenPandaz]

It looks like this causes issues with other plugins. Can you take a look please?

[FrozenPandaz]

Instead of monkey patching webpack above, perhaps it is easier to check for the existence of a close method?

if (webpackCompiler.close) {
  webpackCompiler.close(() => {
    subscriber.complete();
  });
} else {
  subscriber.complete();
}

[kazamov]

@FrozenPandaz, but if you check the close method in that case you will have a garbage after release of the Nx 13. If I do not mistake you will remove files with monkey patched code anyway. Thus it looks better in my opinion. Anyway it is up to you

[FrozenPandaz]

Thank you for thinking ahead!

That is okay because it is only 1 place. Please add a TODO comment saying to clean it up the conditional after Nx 13 😄.

[kazamov]

@FrozenPandaz, done. I removed the fallback for webpack 4 and added if statement with TODO.

[FrozenPandaz]

Awesome! Thank you making those changes! LGTM 🎉

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.