Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix reading project config when nx.json doesn't have projects #6802

Merged
merged 1 commit into from Aug 21, 2021
Merged

fix(core): fix reading project config when nx.json doesn't have projects #6802

merged 1 commit into from Aug 21, 2021

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

When projects is not defined in nx.json, readProjectConfiguration fails.

Expected Behavior

When projects is not defined in nx.json, readProjectConfiguration works.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Aug 20, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/AKJmmHQeuwk13SogspYzpYxjXrQL
✅ Preview: Canceled

[Deployment for 44d752d canceled]

AgentEnder
AgentEnder approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nx-cloud
Copy link

nx-cloud bot commented Aug 20, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 44d752d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=e2e --base=a3c9a63dc2b3662cf3632814d1bfc03f69a68038
#000000 nx affected --target=lint --base=a3c9a63dc2b3662cf3632814d1bfc03f69a68038 --parallel --max-parallel=4
#000000 nx affected --target=test --base=a3c9a63dc2b3662cf3632814d1bfc03f69a68038 --parallel --max-parallel=2
#000000 nx affected --target=build --base=a3c9a63dc2b3662cf3632814d1bfc03f69a68038 --parallel --max-parallel=3
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) August 20, 2021 22:05
@FrozenPandaz FrozenPandaz merged commit 4d6b5ff into nrwl:master Aug 21, 2021
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@FrozenPandaz @ManojBahuguna
fix(core): fix reading project config when nx.json doesn't have proje…
3442a99 
…cts (nrwl#6802)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FrozenPandaz @AgentEnder