Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): handle other variants of root paths in visitNotIgnoredFiles #7767

Merged
merged 1 commit into from Nov 17, 2021

Conversation

leosvelperez
Copy link
Member

Current Behavior

The visitNotIgnoredFiles currently supports visiting the root path as long as it is an empty string. Other variants of the root path (e.g. ".") are not supported and cause the ignore package to throw an error.

Expected Behavior

The visitNotIgnoredFiles should handle correctly any variant of a root path.

Related Issue(s)

Fixes #7642

@leosvelperez leosvelperez self-assigned this Nov 17, 2021
@vercel
Copy link

vercel bot commented Nov 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CKwJtZDV3ciLPFrAGcbD9FXU4FgW
✅ Preview: Canceled

@leosvelperez leosvelperez merged commit 446ef6e into nrwl:master Nov 17, 2021
@leosvelperez leosvelperez deleted the ignore-root-path-issue branch November 17, 2021 14:02
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Unable to move a library using nx g @nrwl/workspace:move
1 participant