Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): consider tailwind usage when invalidating stylesheet caching in publishable libraries #7804

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

leosvelperez
Copy link
Member

Current Behavior

The package executor caching for stylesheets is too aggressive and it doesn't consider Tailwind directives which can cause different outputs based on the Tailwind configuration. Therefore, changes to the Tailwind configuration don't get reflected unless the ng-packagr cache is cleared.

Expected Behavior

Changes to the Tailwind configuration of publishable libraries should be respected and reflected in the compiled output.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Nov 19, 2021
@vercel
Copy link

vercel bot commented Nov 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/HTRmj9LzooQB7Ng8nb7hQUDmwHoy
✅ Preview: Canceled

[Deployment for 8baa148 canceled]

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit f208afc into nrwl:master Nov 19, 2021
@leosvelperez leosvelperez deleted the fix-package-style-cache branch November 19, 2021 14:47
FrozenPandaz pushed a commit that referenced this pull request Nov 19, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants