Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): handle sass imports without tilde of node_modules packages #8038

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

Building a library that has SCSS imports without a tilde to node_modules packages with either @nrwl/angular:ng-packagr-lite or @nrwl/angular:package causes the build to fail.

Expected Behavior

SCSS imports should be correctly handled by the @nrwl/angular:ng-packagr-lite and @nrwl/angular:package executors.

Related Issue(s)

Fixes #8024

@leosvelperez leosvelperez self-assigned this Dec 7, 2021
@vercel
Copy link

vercel bot commented Dec 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/B1arXnU4dcH274ttBsaz4iqx84rH
✅ Preview: Canceled

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit a11f7e7 into nrwl:master Dec 7, 2021
@leosvelperez leosvelperez deleted the fix-ng-packagr-executors-css-imports branch December 7, 2021 16:43
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package builder does not allow components to import 3rd party scss
2 participants