Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): adjust how to pass information down to swc cli #8298

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Dec 24, 2021

Current Behavior

  • The SWC CLI is executed from root which requires some weird handling for dist path for the SWC compiler to put the out files.
  • The generated .swcrc with exclude is being used for compilation but this fails swc/jest as swc/jest also looks at the same .swcrc. With exclude, test files aren't included in the compilation for swc/jest

Expected Behavior

  • SWC CLI is now executed from the current project root
  • dist is straight from outputPath with suffix /src
  • .swcrc does not include exclude field anymore and is meant to be used by other toolings. build uses a temp .swcrc that was generated during build time

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Dec 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/A6TRzWwAHa62Y2RJ4nrpaasMQ24w
✅ Preview: Canceled

[Deployment for d9dd36c canceled]

@nartc nartc marked this pull request as ready for review January 4, 2022 16:04
@nartc nartc requested a review from jaysoo January 4, 2022 16:17
@vsavkin vsavkin merged commit 22c6ddb into master Jan 6, 2022
@bcabanes bcabanes deleted the swc-revisit branch January 6, 2022 22:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants