[nestjs] Incorrect shutdown

[mark-b-ab]

Starting 13.8.4 (when @nrwl/node:execute was replaced by @nrwl/node:node) Nx incorrectly handles shutdown on NestJS apps with shutdown hook.

Steps to Reproduce

1. Create an empty NestJS app using Nx
2. Use the following AppModule
3. Enable shutdown hooks
4. Start the app using nx serve
5. Send SIGTERM (Ctrl + C)

Current Behavior

1 log message:

• onModuleDestroy before wait

Expected Behavior

3 log messages:

• onModuleDestroy before wait
• onModuleDestroy after wait
• onApplicationShutdown

Environment

   Node : 17.5.0
   OS   : darwin arm64
   yarn : 3.2.0
   
   nx : 13.8.5
   @nrwl/angular : undefined
   @nrwl/cli : 13.8.5
   @nrwl/cypress : undefined
   @nrwl/detox : undefined
   @nrwl/devkit : 13.8.5
   @nrwl/eslint-plugin-nx : 13.8.5
   @nrwl/express : undefined
   @nrwl/jest : 13.8.5
   @nrwl/js : 13.8.5
   @nrwl/linter : 13.8.5
   @nrwl/nest : 13.8.5
   @nrwl/next : undefined
   @nrwl/node : 13.8.5
   @nrwl/nx-cloud : undefined
   @nrwl/react : undefined
   @nrwl/react-native : undefined
   @nrwl/schematics : undefined
   @nrwl/storybook : undefined
   @nrwl/tao : 13.8.5
   @nrwl/web : undefined
   @nrwl/workspace : 13.8.5
   typescript : 4.6.2
   rxjs : 7.5.4
   ---------------------------------------
   Community plugins:
         @nx-tools/nx-docker: 2.3.0

[mveeravalli]

Facing the same issue, any temporary fix available ?

[mark-b-ab]

nope(

[mark-b-ab]

What I did is reverting @nrwl/node to 13.8.3

[mark-b-ab]

Found the issue: Multiple signals are received by the app:

Received SIGINT
Received SIGINT
Received SIGTERM

On the first signal, NestJS removes all listeners, and the next signal kills the app

A simple way to fix this issue is to add the following code to your main.ts file before NestJS bootstrap.

import { ShutdownSignal } from '@nestjs/common';

Object.values(ShutdownSignal).forEach((signal) => {
  process.on(signal, () => {});
});

It will add additional listeners to signals, and the app will not be killed but gracefully stopped by NestJS.

[nartc]

@mark-b-ab the bug seems to happen if I have async operations inside of the hooks. Just want to give you an update. I'm still looking into the process handling
#10292

[jkossis]

@nartc why was this closed?

Using latest everything from nx, I am still experiencing the original behavior noted by @mark-b-ab.

[jkossis]

@nartc bumping this again.

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.