feat(react): add ability to serve remote apps in dev or static mode #9893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
nx14-serve-static-remotes
branch
from
de62f4e
to
e98c8f9
Compare
jaysoo
force-pushed
the
nx14-serve-static-remotes
branch
from
e98c8f9
to
5390f5d
Compare
| export function loadModuleFederationConfigFromContext( | ||
| context: ExecutorContext | ||
| ): ModuleFederationConfig { | ||
| const p = context.workspace.projects[context.projectName]; |
There was a problem hiding this comment.
Small nitpick here should this be project?
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
serve-statictarget for apps generated with@nrwl/react:hostor@nrwl/react:remote. It is used by the@nrwl/react:module-federation-dev-serverto serve remote apps from dist (i.e. built artifact), intended when serving a host/shell app.So users can do:
And the serve target would only run dev-server for app1 and app3--app2 and others will serve from dist.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #