Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dep-graph): fix display of nested workspaceLayout directories #9918

Conversation

philipjfulcher
Copy link
Collaborator

Current Behavior

  • Workspaces with nested directories in their workspaceLayout configuration do not display these nested directories correctly.

For example, with a workspaceLayout of

{
  "appsDir": "surfaces/apps",
  "libsDir": "surfaces/libs"
}

All of the apps would appear to be under a nested folder of surfaces/apps. Instead, they should be created as being in the root directory of apps.

Expected Behavior

  • Workspaces with nested directories in their workspaceLayout configuration display these nested directories correctly.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 21, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5216cc0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@philipjfulcher philipjfulcher self-assigned this Apr 21, 2022
@vercel
Copy link

vercel bot commented Apr 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Apr 21, 2022 at 3:15AM (UTC)

@philipjfulcher philipjfulcher enabled auto-merge (squash) April 21, 2022 03:12
@philipjfulcher philipjfulcher merged commit 5f12ce0 into nrwl:master Apr 21, 2022
@philipjfulcher philipjfulcher deleted the philip/fix-dep-graph-workspace-layout branch November 27, 2022 22:36
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant