Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): add missing --tag flag to the publish command #10014

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Apr 26, 2022

Current Behavior

tag is being passed in but not actually used in the final npm publish command

Expected Behavior

npm publish command should use the --tagflag

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 26, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit adb8eb4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Apr 26, 2022 at 8:31PM (UTC)

@nartc nartc requested a review from jaysoo April 26, 2022 20:30
@FrozenPandaz FrozenPandaz merged commit 5dbc98f into master Apr 26, 2022
@jaysoo jaysoo deleted the publish-script-missing-tag branch April 27, 2022 13:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants