fix(misc): move library without given importPath default to contain slashes #11869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jordems
changed the title
…ntain slashes `nx g mv --projectName lib/child-1 --destionation lib/child-2` would result in the ts-config and import paths of `@<project>/lib-child-2` when it is expected to be `@<project>/lib/child-2` Closes nrwl#9281
jordems
force-pushed
the
9281-fix-mv-generator-default-import-paths
branch
from
475f63f
to
536fcf2
Compare
|
I noticed this too, and was thinking about fixing this myself. Thank you, @jordems! |
FrozenPandaz
approved these changes
Sep 22, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Performing:
nx g mv --projectName lib/child-1 --destination lib/child-2would result in the ts-config and import paths of files being
@<project>/lib-child-2Expected Behavior
It is expected to be
@<project>/lib/child-2.As that is how the
nx gcreation works when creating a library.Related Issue(s)
Fixes #9281