fix(core): properly serialize override with object arg for command line

[lukasalphta]

Avoid printing object args as [object Object] in terminal.

Current Behavior

When we pass not nx arguments as object

nx e2e myapp6467039-e2e --env.cliArgs="i am from the cli args" 

the task runner will print [object Object] instead of the passed arguments

> nx run myapp6467039-e2e:e2e --env=[object Object]

Expected Behavior

It should print unparsed arguments

>  nx run myapp6467039-e2e:e2e  --env.cliArgs="i am from the cli args" 

Related Issue(s)

Fixes #10808

[nx-cloud-staging]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 74bbe77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=e2e --base=0f2b89b00e301f0ac56fdc390e04bfcc20d41da8 --head=74bbe770dd9a5fbfc87a6d09ade3fceeee6d6ba6 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1
• nx affected --target=test --base=0f2b89b00e301f0ac56fdc390e04bfcc20d41da8 --head=74bbe770dd9a5fbfc87a6d09ade3fceeee6d6ba6 --parallel=1
• nx affected --target=build --base=0f2b89b00e301f0ac56fdc390e04bfcc20d41da8 --head=74bbe770dd9a5fbfc87a6d09ade3fceeee6d6ba6 --parallel=3
• nx-cloud record -- yarn depcheck
• nx affected --target=lint --base=0f2b89b00e301f0ac56fdc390e04bfcc20d41da8 --head=74bbe770dd9a5fbfc87a6d09ade3fceeee6d6ba6 --parallel=3
• nx-cloud record -- yarn nx workspace-lint
• nx-cloud record -- yarn check-lock-files
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn nx format:check --base=0f2b89b00e301f0ac56fdc390e04bfcc20d41da8 --head=74bbe770dd9a5fbfc87a6d09ade3fceeee6d6ba6
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn documentation
• nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	Oct 27, 2022 at 6:46PM (UTC)

[lukasalphta]

Hi @FrozenPandaz, after a second look at my PR I started questioning what the expected behavior should be. In the previous versions before this problem occurred, arguments passed with dot notation were printed in the same way in terminal.

Running

nx e2e myapp6467039-e2e --env.cliArgs="i am from the cli args"

would have printed

> nx run myapp6467039-e2e:e2e --env.cliArgs="i am from the cli args"

Could you confirm that this would be the expected behavior here as well? Then I could rework the PR.

[FrozenPandaz]

Sorry, it's been a while. Thank you so much for your work here! The fix was in the right place but I found some code that we can reuse.

This logic isn't the cleanest... I think this logic should be kind of unnecessary. Rather than unparsing the parsed arguments which were actually passed, there should be a way where we can directly keep the arguments which were actually passed. We will look into in the near future.

For now, I fixed it a simpler way without exposing the underlying parsing of a single option. We actually have this code elsewhere so I moved it from there. I saw you actually had some logic which used the underlying parsing of a single option but I'm hoping we will fix it in a better strategy soon. Let's go with this fix for now, so that your issue is resolved while we work on a better strategy for this.

Again, thank you so much for your work. I can take it from here 👍

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.