feat(core): add daemon watcher filters #13229
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…emap, then handle created files
| @@ -71,14 +73,24 @@ export function addUpdatedAndDeletedFiles( | |||
| collectedDeletedFiles.add(f); | |||
| } | |||
|
|
|||
| notifyFileWatcherSockets(null, updatedFiles, deletedFiles); | |||
There was a problem hiding this comment.
Only do it if you have updated or deleted files
| cachedSerializedProjectGraphPromise = | ||
| processFilesAndCreateAndSerializeProjectGraph(); | ||
| await cachedSerializedProjectGraphPromise; | ||
|
|
||
| notifyFileWatcherSockets(createdFiles, null, null); |
There was a problem hiding this comment.
Only do it if you have created files
| return registeredFileWatcherSockets.length > 0; | ||
| } | ||
|
|
||
| export async function notifyFileWatcherSockets( |
There was a problem hiding this comment.
I'd remove "async". We invoke this function in the fire and forget fashion without awaiting. IntelliJ will actually complain that you invoke a function returning promise and not awaiting
| return; | ||
| } | ||
|
|
||
| await queue.sendToQueue(async () => { |
| })), | ||
| ]; | ||
|
|
||
| for (const changedFile of allChangedFiles) { |
There was a problem hiding this comment.
Do you know how slow this can be? Imagine if reformated 1000 files in a big workspace.
Currently it's O(Number of changes files * Number of files)
I think a better way might be to create a map from files to projects. You complexity will change to O(Number of files + number of changed files)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #