Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): replace createReactEslintJson with extendReactEslintJson #13431

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

meeroslav
Copy link
Contributor

Current Behavior

For all react-driven project scaffolding, we use createReactEslintJson that re-generates the eslint config.
This new config overrides the auto-generated eslint config and gets in the way of standalone/root functionality.

Expected Behavior

The react-project should only extend the existing eslint config with necessary extends + any other specific configs, instead of replacing the entire config.

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Nov 28, 2022
@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 28, 2022 at 10:37AM (UTC)

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Nov 28, 2022
@meeroslav meeroslav merged commit 9a0db48 into nrwl:master Nov 28, 2022
@meeroslav meeroslav deleted the linter-fix2 branch March 14, 2023 22:17
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant