Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): inform user vite is used if project uses vite #13499

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

mandarini
Copy link
Member

If a project is using vite, then Storybook will generate with vite configuration, as well, no matter the bundler the user passed.

Also, Storybook generator does not install the vite dependency if bundler is not set as vite by the user.

  • inform user that if project uses vite storybook will be configured for vite, too
  • install vite if project is configured using vite even if user provided different builder

@mandarini mandarini self-assigned this Nov 30, 2022
@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 30, 2022 at 11:31AM (UTC)

@mandarini mandarini enabled auto-merge (squash) November 30, 2022 11:32
@mandarini mandarini merged commit f545b29 into nrwl:master Nov 30, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant