Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prevent peer deps from ending up as dev deps in create package json #13502

Merged
merged 6 commits into from
Dec 1, 2022

Conversation

meeroslav
Copy link
Contributor

Current Behavior

When generating package.json for the project, we treat peer dependencies as direct dependencies, and if already defined in the peerDependencies we make a duplicate.

Expected Behavior

The peer dependencies nature should be respected in the generated package.json and there should not be duplicates.

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: core core nx functionality label Nov 30, 2022
@meeroslav meeroslav self-assigned this Nov 30, 2022
@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 8:16AM (UTC)

@meeroslav meeroslav changed the title fix(core): keep peer dependencies in create package json fix(core): prevent peer deps from ending up as dev deps in create package json Dec 1, 2022
@meeroslav meeroslav merged commit 1a3cc51 into nrwl:master Dec 1, 2022
@meeroslav meeroslav deleted the package-create-peer-fix branch March 14, 2023 22:17
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant