New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vite): allow user to set their custom target for transform #13691
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4697222
to
b5473ee
Compare
b5473ee
to
a26a9ed
Compare
04edc92
to
9b4fd95
Compare
488ba75
to
2c658d6
Compare
2c658d6
to
1dd8aea
Compare
1dd8aea
to
f72cc4e
Compare
f72cc4e
to
89ab446
Compare
89ab446
to
199b98e
Compare
199b98e
to
98b1d82
Compare
98b1d82
to
23c6be5
Compare
23c6be5
to
cb2f63f
Compare
cb2f63f
to
4d6ba06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
There is also the enquirer
package that needs to be added to @nrwl/vite/package.json
.
b466f4c
to
d89113b
Compare
d89113b
to
b7fb106
Compare
b7fb106
to
261e4c6
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
If a project has more than one
build
orserve
(or eventest
) target, the@nrwl/vite:configuration
generator will convert the first one it finds. We can allow the user to manually specify, if they want, which target they want to change.This could be a niche use case, since most probably the new setup (folder/file structure) will just work for
vite
, but we cannot really assume, and also someone could want to use multiple custom executors, too. I think it's fair to allow the user to specify the target they want to convert.The PR also improves a bit the process of converting, by introducing some errors and interractivity, in case the project Nx is trying to convert does not have any executors we recognize, for example.