-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testing): remove unused dependencies from @nrwl/cypress #13771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
28ae096
to
9dc78d8
Compare
9dc78d8
to
253c905
Compare
Phillip9587
reviewed
Dec 13, 2022
packages/cypress/src/generators/cypress-component-project/cypress-component-project.ts
Outdated
Show resolved
Hide resolved
253c905
to
2e6208b
Compare
Phillip9587
reviewed
Dec 13, 2022
mandarini
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
mandarini
reviewed
Dec 14, 2022
mandarini
reviewed
Dec 14, 2022
packages/cypress/src/generators/cypress-component-project/cypress-component-project.ts
Outdated
Show resolved
Hide resolved
mandarini
reviewed
Dec 14, 2022
packages/cypress/src/generators/cypress-component-project/cypress-component-project.ts
Outdated
Show resolved
Hide resolved
91d1dba
to
0b38578
Compare
0b38578
to
d9ac4af
Compare
Phillip9587
added a commit
to Phillip9587/nx
that referenced
this pull request
Jan 9, 2023
@cypress/webpack-preprocessor support was removed in nrwl#13771
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes webpack and babel dependencies from
@nrwl/cypress
. They aren't needed since Cypress can process TS files out of the box.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #