Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): remove unused dependencies from @nrwl/cypress #13771

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Dec 12, 2022

This PR removes webpack and babel dependencies from @nrwl/cypress. They aren't needed since Cypress can process TS files out of the box.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Dec 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 4:43AM (UTC)

@jaysoo jaysoo force-pushed the feat/remove-webpack-from-cypress branch from 28ae096 to 9dc78d8 Compare December 12, 2022 17:53
@jaysoo jaysoo force-pushed the feat/remove-webpack-from-cypress branch from 9dc78d8 to 253c905 Compare December 12, 2022 18:07
Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jaysoo jaysoo force-pushed the feat/remove-webpack-from-cypress branch 2 times, most recently from 91d1dba to 0b38578 Compare December 15, 2022 04:36
@jaysoo jaysoo force-pushed the feat/remove-webpack-from-cypress branch from 0b38578 to d9ac4af Compare December 15, 2022 04:38
@jaysoo jaysoo marked this pull request as ready for review December 15, 2022 04:39
@jaysoo jaysoo enabled auto-merge (squash) December 15, 2022 04:39
@jaysoo jaysoo merged commit 4f9b9d4 into nrwl:master Dec 15, 2022
Phillip9587 added a commit to Phillip9587/nx that referenced this pull request Jan 9, 2023
@cypress/webpack-preprocessor support was removed in nrwl#13771
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants