Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): support custom outExtension for ESM and CJS (e.g. .mjs) #13985

merged 1 commit into from Dec 22, 2022


Copy link

@jaysoo jaysoo commented Dec 22, 2022

This PR adds a check for user-defined outExtension before providing our own.

This allows .mjs to be used for ESM, and .js to be used for CJS. The executor will check to make sure the extensions are valid (e.g. .cjs cannot be used for ESM, and .mjs cannot be used for CJS).

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #13890

Copy link

vercel bot commented Dec 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 22, 2022 at 4:43PM (UTC)

@jaysoo jaysoo merged commit 98ed2ea into nrwl:master Dec 22, 2022
13 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

@nrwl/esbuild build command not supporting .mjs output file
2 participants