feat(angular): add parent flag to ngrx generator #14105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
approved these changes
Jan 3, 2023
nartc
reviewed
Jan 3, 2023
| ): void { | ||
| const modulePath = options.module; | ||
| const sourceText = tree.read(modulePath, 'utf-8'); | ||
| const parentPath = options.module ?? options.parent; |
There was a problem hiding this comment.
nit: since both module and parent are optional now but I think we have to have at least either one. parent will be made required as we remove module in the future but can/should we put a check for them here, and log an actionable error message for now?
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently only have the flag
--modulefor the NgRx generator, however, this does not make sense with Standalone Components.Expected Behavior
Deprecate the
--moduleflag in favour of the new--parentflag.--parentflag behaviour will mimic--modulefor now, but will eventually be expanded to include support for Standalone Components