Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): return baseUrl from storybook and use in cypress #14306

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

mandarini
Copy link
Member

Pass the port and the baseUrl from the Storybook devServer to the cypress executor.

Why this schema?

Reason why we are using the info?: { port: number; baseUrl?: string }; schema:

The @storybook/angular:start-storybook executor returns:

return { success: true, info: { port } };

So we want to keep a consistent schema to our @nrwl/storybook:storybook executor.

Now, since we are in control of what the @nrwl/storybook:storybook executor returns and what the options passed to it are, we can generate/infer the whole baseUrl that it ends up with. So, we are passing that to cypress.

@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 12, 2023 at 2:50PM (UTC)

@mandarini mandarini enabled auto-merge (squash) January 12, 2023 14:54
@mandarini mandarini merged commit a5766a8 into nrwl:master Jan 12, 2023
@raybotha
Copy link

This broke Storybook 6.x
#14373

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Cypress E2E on Storybook library parallel runs - could not verify that this server is running
3 participants