Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): wildcard sourceTag should be respected for banned imports #14418

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jan 17, 2023

Current Behavior

Wildcard constraints sourceTag: * are never matched for constraints.

Expected Behavior

Constraints should use the same hasTag functionality as the rest of the lint runtime helpers.

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Jan 17, 2023
@vercel
Copy link

vercel bot commented Jan 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 17, 2023 at 1:30PM (UTC)

@meeroslav meeroslav enabled auto-merge (squash) January 17, 2023 09:47
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
@meeroslav meeroslav deleted the fix-banned-import branch April 27, 2023 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants