Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ngrx attaching to route and non-standalone apis for 14 #14489

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 19, 2023

Current Behavior

NgRx is not attaching to routes correctly and is trying to use standalone apis when NgRx 14 doesn't have them.

Expected Behavior

Attach to routes correctly, and throw error is someone has passed a path to a routes file with NgRx 14

@Coly010 Coly010 self-assigned this Jan 19, 2023
@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 20, 2023 at 0:25AM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Jan 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8eda151. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


⌛ The following target is in progress

🟥 Failed Commands
nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
nx affected --target=test --base=01b42896a2f94436f512c88d209e5fd34b8f8872 --head=d2fd0cba6e4ff7bfa871763bac4a1dbd3374a501 --parallel=1
nx affected --target=build --base=01b42896a2f94436f512c88d209e5fd34b8f8872 --head=d2fd0cba6e4ff7bfa871763bac4a1dbd3374a501 --parallel=3
✅ Successfully ran 34 targets

Sent with 💌 from NxCloud.

@Coly010 Coly010 force-pushed the angular/ngrx-backwards-compat branch 4 times, most recently from 552ce1b to e04a165 Compare January 19, 2023 19:57
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left a nit suggestion to simplify a bit the logic, feel free to disregard it.

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
@Coly010 Coly010 force-pushed the angular/ngrx-backwards-compat branch from d2fd0cb to 8eda151 Compare January 20, 2023 12:24
@Coly010 Coly010 merged commit b076f03 into nrwl:master Jan 20, 2023
@Coly010 Coly010 deleted the angular/ngrx-backwards-compat branch January 20, 2023 12:58
FrozenPandaz pushed a commit that referenced this pull request Jan 20, 2023
…14489)

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
(cherry picked from commit b076f03)
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants