-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): ngrx attaching to route and non-standalone apis for 14 #14489
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
552ce1b
to
e04a165
Compare
packages/angular/src/generators/ngrx/lib/add-imports-to-module.ts
Outdated
Show resolved
Hide resolved
e04a165
to
6f10cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a nit suggestion to simplify a bit the logic, feel free to disregard it.
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
d2fd0cb
to
8eda151
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
NgRx is not attaching to routes correctly and is trying to use standalone apis when NgRx 14 doesn't have them.
Expected Behavior
Attach to routes correctly, and throw error is someone has passed a path to a routes file with NgRx 14