Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ensure required peer deps are installed when migrating from angular cli workspaces #14766

Merged

Conversation

leosvelperez
Copy link
Member

Install required peerDependencies of the @nrwl/angular plugin when migrating from an Angular CLI workspace to an Nx workspace.

@leosvelperez leosvelperez self-assigned this Feb 2, 2023
@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 2, 2023 at 9:19AM (UTC)

@leosvelperez leosvelperez force-pushed the angular/ng-add-install-peer-deps branch from 0930716 to 2ccceb4 Compare February 2, 2023 09:03
@leosvelperez leosvelperez force-pushed the angular/ng-add-install-peer-deps branch from 2ccceb4 to 4d2ea41 Compare February 2, 2023 09:18
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment :) looks good otherwise

@leosvelperez leosvelperez merged commit 17aa895 into nrwl:master Feb 2, 2023
@leosvelperez leosvelperez deleted the angular/ng-add-install-peer-deps branch February 2, 2023 09:47
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants