Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fallback to buildTarget.options if no configuration provided #14952

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 13, 2023

Current Behavior

If no configuration is provided as the browserTarget string then the serve falls over

Expected Behavior

Fallback to the buildTarget.options when no configuration provided. Assume that the buildTarget.options has all necessary options defined in this scenario

Related Issue(s)

Fixes #

@Coly010 Coly010 self-assigned this Feb 13, 2023
@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 13, 2023 at 10:22AM (UTC)

@Coly010 Coly010 merged commit 91117c9 into nrwl:master Feb 13, 2023
@Coly010 Coly010 deleted the angular/fix-incremental-build-serve branch February 13, 2023 11:29
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants