Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-native): run-android support --active-arch-only flag #15050

Merged
merged 2 commits into from
Feb 17, 2023
Merged

feat(react-native): run-android support --active-arch-only flag #15050

merged 2 commits into from
Feb 17, 2023

Conversation

ste7en
Copy link
Contributor

@ste7en ste7en commented Feb 16, 2023

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #15045

Stefano Formicola added 2 commits February 16, 2023 12:59
feat(react-native): add activeArchOnly run-android option flag
a96114d 
This solves issue nrwl#15045 and adds the possibility to pass as argument to React Native CLI's
run-android the flag --active-arch-only to only build for the current architecture, reducing native
build times by up to 75%.

closed nrwl#15045
docs(react-native): update run-android docs
c74c1e5
@vercel
Copy link

vercel bot commented Feb 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 0:11AM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Feb 16, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c74c1e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@xiongemi
Copy link
Collaborator

thanks for submitting this pr. after I took a look, I realized that there are more options needed to be updated. i will submit a separate pr to update them all.

@xiongemi xiongemi closed this Feb 16, 2023
@xiongemi xiongemi reopened this Feb 17, 2023
@xiongemi
Copy link
Collaborator

there are changes in the new version of @react-native-community/cli, which has not been released yet. your change is fine. I am going to merge it for now.

@xiongemi xiongemi merged commit b7272e3 into nrwl:master Feb 17, 2023
@ste7en
Copy link
Contributor Author

ste7en commented Feb 17, 2023

Great! 😄 Thank you @xiongemi

@ste7en ste7en deleted the feat/run-android-active-archs branch February 20, 2023 08:23
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xiongemi xiongemi xiongemi approved these changes

@jaysoo jaysoo Awaiting requested review from jaysoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@nrwl/react-native:run-android could support active-arch-only flag
2 participants
@ste7en @xiongemi