Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ngrx should attach to parent routes correctly #15221

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 24, 2023

Current Behavior

Attaching ngrx providers to a route either intentionally or by using the default route can fail

Expected Behavior

Attaching a route should not fail

Related Issue(s)

Fixes #15119

@Coly010 Coly010 self-assigned this Feb 24, 2023
@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 24, 2023 at 3:01PM (UTC)

@Coly010 Coly010 marked this pull request as ready for review February 24, 2023 13:12
@Coly010 Coly010 enabled auto-merge (squash) February 24, 2023 13:39
@Coly010 Coly010 merged commit 88199e5 into nrwl:master Feb 24, 2023
@Coly010 Coly010 deleted the angular/fix-ngrx-routes branch February 24, 2023 15:26
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants