Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): make webpack-browser executor watch changes correctly in incremental builds setups #15222

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 24, 2023

Current Behavior

Building an application in watch mode using the @nrwl/angular:webpack-browser executor doesn't rebuild with code changes in dependent libraries.

Expected Behavior

Building an application in watch mode using the @nrwl/angular:webpack-browser executor should rebuild with code changes in dependent libraries.

Related Issue(s)

Fixes #15191

@leosvelperez leosvelperez self-assigned this Feb 24, 2023
@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 24, 2023 at 0:44AM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review February 24, 2023 13:44
@leosvelperez leosvelperez merged commit b488f64 into nrwl:master Feb 24, 2023
@leosvelperez leosvelperez deleted the angular/webpack-browser-watch-incremental-builds branch February 24, 2023 14:10
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watching changes with incremental app "build" does not work
3 participants