Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): add missing types for tsconfigs #15260

Merged

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

missing types for compiler options that correct type import.meta for vite and vitest, mainly import.meta.env shows a TS error because it's missing vite/client types

Expected Behavior

vite types are added to the vite related tsconfigs so that import.meta is correctly typed

Related Issue(s)

Fixes #14176

@vercel
Copy link

vercel bot commented Feb 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 2, 2023 at 5:54PM (UTC)

@barbados-clemens barbados-clemens self-assigned this Feb 25, 2023
@barbados-clemens barbados-clemens added the scope: bundlers Issues related to webpack, rollup label Feb 25, 2023
@barbados-clemens barbados-clemens merged commit 2e449da into nrwl:master Mar 2, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: bundlers Issues related to webpack, rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong types in tsconfig.json in generated react application with vite
2 participants