Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle .nxignore properly for the native hasher #15420

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Mar 3, 2023

Current Behavior

Currently the native hasher only uses the first line of the .nxignore file, thus missing the rest of the ignores

Expected Behavior

The .nxignore file should be read entirely and all contents should be handled

Related Issue(s)

Fixes #15377

@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 1:10PM (UTC)

let workspace_root = Path::new(&workspace_root);
walker.add_ignore(workspace_root.join(".nxignore"));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the add_ignore here only used the first item in the ignore file 🤨

@FrozenPandaz FrozenPandaz merged commit b0ab036 into nrwl:master Mar 3, 2023
@Cammisuli Cammisuli deleted the fix_native_nxignore branch March 3, 2023 15:29
FrozenPandaz pushed a commit that referenced this pull request Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

15.8.1-3: .nxignore not respected in native hasher
2 participants