-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): handle .nxignore properly for the native hasher #15420
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
let workspace_root = Path::new(&workspace_root); | ||
walker.add_ignore(workspace_root.join(".nxignore")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, the add_ignore
here only used the first item in the ignore file 🤨
(cherry picked from commit b0ab036)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Currently the native hasher only uses the first line of the .nxignore file, thus missing the rest of the ignores
Expected Behavior
The .nxignore file should be read entirely and all contents should be handled
Related Issue(s)
Fixes #15377