Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): filter out deps early based on shared config from module federation #15654

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 14, 2023

Current Behavior

The withModuleFederation helpers warn when a project dep is not found in the package.json even if it's excluded in the shared function.

Expected Behavior

The withModuleFederation helpers don't warn when a project dep is not found in the package.json but it's excluded in the shared function.

Related Issue(s)

Fixes #15456

@leosvelperez leosvelperez self-assigned this Mar 14, 2023
@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 14, 2023 at 10:10AM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review March 14, 2023 11:15
@leosvelperez leosvelperez merged commit e2a2703 into nrwl:master Mar 14, 2023
@leosvelperez leosvelperez deleted the misc/mf-filter-out-excluded-shared branch March 14, 2023 11:34
FrozenPandaz pushed a commit that referenced this pull request Mar 15, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants