Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ignore missing modules.yaml during postinstall #15660

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Mar 14, 2023

Pnpm lockfile parsing fails on postinstall since there is no .modules.yaml. The parsing should fail silently in such cases, since the first nx command run will recreate the graph anyway.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #15642
Fixes #15656

@meeroslav meeroslav self-assigned this Mar 14, 2023
@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 0:34AM (UTC)

@FrozenPandaz FrozenPandaz merged commit 8a0398d into nrwl:master Mar 14, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 15, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
@meeroslav meeroslav deleted the fix-pnpm-missing-modules branch April 27, 2023 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants