Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): improve and simplify e2e tests #15734

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Mar 17, 2023

Make improvements to Storybook e2e tests

  • Disable tests that will fail with Storybook 6.5
  • Improve titles
  • Reduce timeout/wait time

@vercel
Copy link

vercel bot commented Mar 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2023 at 3:14PM (UTC)

@mandarini mandarini changed the title Feat/sb e2e improvements fix(storybook): improve and simplify e2e tests Mar 17, 2023
@mandarini mandarini self-assigned this Mar 17, 2023
@mandarini mandarini marked this pull request as ready for review March 17, 2023 16:06
e2e/storybook/src/storybook.test.ts Show resolved Hide resolved
e2e/storybook/src/storybook.test.ts Show resolved Hide resolved
e2e/storybook/src/storybook.test.ts Outdated Show resolved Hide resolved
e2e/storybook/src/storybook-nested.test.ts Show resolved Hide resolved
e2e/storybook/src/storybook-nested.test.ts Show resolved Hide resolved
e2e/storybook/src/storybook-nested.test.ts Show resolved Hide resolved
docs/shared/mental-model/large-tasks.json Outdated Show resolved Hide resolved
@meeroslav
Copy link
Contributor

Can you please rebase to the latest master so it's easier to track the delta of changes?

@mandarini mandarini merged commit 4e2b07e into nrwl:master Mar 27, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants