fix(nextjs): handle buildable libs correctly #15795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d39df2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/nextjs-buildable-libs
branch
from
6ef47f2
to
d39df2c
Compare
jaysoo
commented
Mar 21, 2023
| @@ -134,7 +134,7 @@ export function withNx( | |||
| } = getNxContext(graph, originalTarget); | |||
| const projectDirectory = projectNode.data.root; | |||
|
|
|||
| if (!options.buildLibsFromSource && targetName) { | |||
| if (options.buildLibsFromSource === false && targetName) { | |||
There was a problem hiding this comment.
This is the fix, because we're not getting the default value from schema.json so we need to check if it is explicitly set to false, not just falsy.
ndcunningham
approved these changes
Mar 21, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 22, 2023
(cherry picked from commit 63cdddf)
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 23, 2023
(cherry picked from commit 63cdddf)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method to determine incremental builds is broken. This PR patches that logic.
Current Behavior
Buildable libs cannot be consumed unless it is built.
Expected Behavior
Buildable libs should build from source unless
--buildLibsFromSource=falseis passed.Related Issue(s)
Fixes #15785