Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): host and remote app generation with directory #16113

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 5, 2023

Current Behavior

Passing a directory option to remote and host generator that contains a layout directory causes an incorrect project name resolution in the generators.
This leads to being unable to find the correct project in the workspace.

Expected Behavior

The layout directory should be extracted if it exists, therefore the app name can be resolved correctly.

Related Issue(s)

Fixes #16083

@Coly010 Coly010 self-assigned this Apr 5, 2023
@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 5, 2023 10:20am

@Coly010 Coly010 merged commit 44c5471 into nrwl:master Apr 5, 2023
@Coly010 Coly010 deleted the angular/fix-remote-generation branch April 5, 2023 13:13
FrozenPandaz pushed a commit that referenced this pull request Apr 11, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/angular:remote not working when using directory option
2 participants