Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): default webpack build to not perform default optimizations for Node #16625

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 27, 2023

When the target is Node, we don't want Webpack to perform any optimizations by default, or else things like process.env.NODE_ENV gets replaced at build time.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #16601

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 10:33pm

@github-actions
Copy link

github-actions bot commented May 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nest]: process.env['NODE_ENV'] lost after webpack build
2 participants