Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): dont throw if no project-level tsconfig #18027

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

Throws if it does not find .storybook/tsconfig.json or project's tsconfig.json.

Expected Behavior

Should not throw.

Related Issue(s)

Fixes #18014

@mandarini mandarini requested a review from a team as a code owner July 7, 2023 16:00
@mandarini mandarini requested a review from jaysoo July 7, 2023 16:00
@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 4:03pm

@mandarini mandarini self-assigned this Jul 7, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 7, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ef9d48f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mandarini mandarini requested review from Coly010 and removed request for jaysoo July 10, 2023 10:46
@mandarini mandarini enabled auto-merge (squash) July 10, 2023 10:46
@mandarini mandarini merged commit 878955b into nrwl:master Jul 10, 2023
15 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jul 10, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
@mandarini mandarini deleted the fix/storybook-dont-fail-tsconfig branch August 22, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run update-16-5-0 from @nx/storybook
2 participants