-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(storybook): use ESM for Storybook configs #18380
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@benmccann thanks for the contribution. :D Your commit had a small issue, but I made the fixes myself to expedite the process. In your original commit you had made the changes to:
instead of
Please take a look at our "contributing to docs" section. The changes need to be made in the Thanks again! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The docs currently show CJS for the Storybook configs
Expected Behavior
When you run
npx sb init
to add Storybook to your project, it creates ESM configs by default. Since users will have ESM config we should use ESM in the docs. Another reason to use ESM is that it is built into the language and more future looking as opposed to the legacy CJS formatRelated Issue(s)
N/A