Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix schema links #18395

Merged
merged 2 commits into from
Aug 17, 2023
Merged

fix(core): fix schema links #18395

merged 2 commits into from
Aug 17, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jul 31, 2023

This issue is blocking the flat config since config reports error

Current Behavior

Schema links point to non-existent pages

Expected Behavior

Schema links should point to active pages

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Jul 31, 2023
@meeroslav meeroslav requested a review from a team as a code owner July 31, 2023 14:07
@meeroslav meeroslav requested a review from vsavkin July 31, 2023 14:07
@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 6:08pm

@@ -1,6 +1,6 @@
{
"$schema": "http://json-schema.org/draft-07/schema",
"$id": "https://nx.dev/core-concepts/configuration#nxjson",
"$id": "https://nx.dev/reference/project-configuration#nxjson",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"$id": "https://nx.dev/reference/project-configuration#nxjson",
"$id": "https://nx.dev/reference/nx-json",

@meeroslav meeroslav enabled auto-merge (squash) August 17, 2023 17:59
@meeroslav meeroslav merged commit ded1543 into nrwl:master Aug 17, 2023
15 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 18, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants